Simplify downloader adapter and update documentation and tests#25
Merged
ecarrenolozano merged 4 commits intomainfrom Mar 10, 2026
Merged
Simplify downloader adapter and update documentation and tests#25ecarrenolozano merged 4 commits intomainfrom
ecarrenolozano merged 4 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to how downloader backends are configured and used in the
ClientCatalogandClientOntologyclasses, making it easier to specify downloader adapters via string names or instances. Documentation and tests are updated to reflect and validate these changes. The most important updates are grouped below.Downloader backend configuration improvements:
"pooch","download_manager") at the client level inClientCatalogandClientOntology. A helper function_resolve_downloaderhandles resolution of string names to adapter instances. [1] [2] [3] [4] [5] [6]Documentation updates:
README.md, tutorial, and reference docs to clarify how to specify downloader backends via string or adapter at the client level, and to note that lower-level components require adapter instances. [1] [2] [3] [4] [5] [6] [7] [8] [9]Testing enhancements:
ClientCatalogandClientOntologycorrectly resolves to the intended downloader adapter, using monkeypatching to simulate backend resolution.loadmethod return values and downloader handling.Logging and configuration tweaks:
04_workdir.yamlfor improved clarity and control.04_workdir.yaml.Miscellaneous improvements:
sandbox/use_case_downloaders.pyfor printing ontology roots after loading.These changes collectively make downloader configuration more flexible and user-friendly, and ensure that documentation and tests accurately reflect the new behavior.